Messages in this thread | | | Date | Tue, 12 Oct 2021 23:59:02 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v1 01/10] powerpc: Move 'struct ppc64_opd_entry' back into asm/elf.h |
| |
On Mon, Oct 11, 2021 at 05:25:28PM +0200, Christophe Leroy wrote: > 'struct ppc64_opd_entry' doesn't belong to uapi/asm/elf.h > > It was initially in module_64.c and commit 2d291e902791 ("Fix compile > failure with non modular builds") moved it into asm/elf.h > > But it was by mistake added outside of __KERNEL__ section, > therefore commit c3617f72036c ("UAPI: (Scripted) Disintegrate > arch/powerpc/include/asm") moved it to uapi/asm/elf.h > > Move it back into asm/elf.h, this brings it back in line with > IA64 and PARISC architectures. > > Fixes: 2d291e902791 ("Fix compile failure with non modular builds") > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
I'd agree with Arnd: this is a reasonable cleanup and nothing should be using it.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |