lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] driver core: Provide device_match_acpi_handle() helper
On Wed, Oct 13, 2021 at 07:47:37PM +0200, Rafael J. Wysocki wrote:
> On Thu, Oct 7, 2021 at 7:18 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > We have couple of users of this helper, make it available for them.
>
> "a couple"?

Yep.

> > EXPORT_SYMBOL(device_match_acpi_dev);
> >
> > +int device_match_acpi_handle(struct device *dev, const void *handle)
>
> Hmmm. Should the second arg be of type acpi_handle?

acpi_handle is not defined as struct and it means the header, where the
prototype is declared, will require acpi.h to be included. Besides that the
whole set of device_match_*() is done by the same prototype, so it can be used
in bus_find_device() calls.

> And doesn't this function belong to the ACPI core? It is related to
> acpi_bus_get_device() and such which are located there.

Same as above. I don't think so.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-10-13 20:25    [W:0.058 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site