lkml.org 
[lkml]   [2021]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] clk: Add write operation for clk_parent debugfs node
On Thu, Oct 07, 2021 at 09:21:58PM +0300, Sam Protsenko wrote:
> Useful for testing mux clocks. One can write the index of the parent to
> be set into clk_parent node, starting from 0. Example
>
> # cd /sys/kernel/debug/clk/mout_peri_bus
> # cat clk_possible_parents
> dout_shared0_div4 dout_shared1_div4
> # cat clk_parent
> dout_shared0_div4
> # echo 1 > clk_parent
> # cat clk_parent
> dout_shared1_div4
>
> CLOCK_ALLOW_WRITE_DEBUGFS has to be defined in drivers/clk/clk.c in
> order to use this feature.

...

> +#ifdef CLOCK_ALLOW_WRITE_DEBUGFS
> + if (core->num_parents > 1)
> + debugfs_create_file("clk_parent", 0644, root, core,
> + &current_parent_rw_fops);
> + else
> +#endif

> + {
> + if (core->num_parents > 0)
> + debugfs_create_file("clk_parent", 0444, root, core,
> + &current_parent_fops);
> + }

Currently there is no need to add the {} along with increased indentation
level. I.o.w. the 'else if' is valid in C.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-10-12 20:56    [W:0.176 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site