Messages in this thread | | | Date | Tue, 12 Oct 2021 23:19:46 +0530 | From | Prasad Malisetty <> | Subject | Re: [PATCH v12 4/5] PCI: qcom: Add a flag in match data along with ops |
| |
On 2021-10-12 19:41, Lorenzo Pieralisi wrote: > On Fri, Oct 08, 2021 at 07:29:05AM +0530, Prasad Malisetty wrote: >> On 2021-10-07 23:33, Stephen Boyd wrote: >> > Quoting Prasad Malisetty (2021-10-07 10:48:42) >> > > Add pipe_clk_need_muxing flag in match data and configure >> > >> > This commit text isn't accurate. The flag isn't added in this patch >> > anymore. Same goes for the commit title/subject. Can you please update >> > it to say something like "Point match data to config struct"? >> > >> Hi Bjorn, >> >> Could you please update below commit text while taking this patch. >> >> "PCI: qcom: Replace ops with struct pcie_cfg in pcie match data. >> >> Add struct qcom_pcie_cfg as match data for all platforms. >> Assign appropriate platform ops into qcom_pcie_cfg and read >> Using of_device_is_compatible in pcie probe. " > > of_device_get_match_data() you mean ? I am confused, please let > me know, I am applying patches 4-5. > > Lorenzo > >> Hi Lorenzo,
Sorry for the confusion. I was trying to add "of_device_get_match_data", you are right.
>> Thanks >> -Prasad >> >> > > If the platform needs to switch pipe_clk_src. >> > > >> > > Signed-off-by: Prasad Malisetty <pmaliset@codeaurora.org> >> > > --- >> > >> > Otherwise code looks fine: >> > >> > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
| |