lkml.org 
[lkml]   [2021]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5.4 49/52] powerpc/bpf: Fix BPF_MOD when imm == 1
On Mon, Oct 11, 2021 at 08:53:16PM -0400, Sasha Levin wrote:
> On Mon, Oct 11, 2021 at 08:24:30PM +0200, Christophe Leroy wrote:
> >
> >
> > Le 11/10/2021 à 19:33, Naresh Kamboju a écrit :
> > > stable-rc 5.4 build failed due this patch.
> > > - powerpc gcc-10-defconfig - FAILED
> > > - powerpc gcc-11-defconfig - FAILED
> > > - powerpc gcc-8-defconfig - FAILED
> > > - powerpc gcc-9-defconfig - FAILED
> > >
> > >
> > > On Mon, 11 Oct 2021 at 19:28, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > From: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> > > >
> > > > [ Upstream commit 8bbc9d822421d9ac8ff9ed26a3713c9afc69d6c8 ]
> > > >
> > > > Only ignore the operation if dividing by 1.
> > >
> > > <trim>
> > >
> > > In file included from arch/powerpc/net/bpf_jit64.h:11,
> > > from arch/powerpc/net/bpf_jit_comp64.c:19:
> > > arch/powerpc/net/bpf_jit_comp64.c: In function 'bpf_jit_build_body':
> > > arch/powerpc/net/bpf_jit_comp64.c:415:46: error: implicit declaration
> > > of function 'PPC_RAW_LI'; did you mean 'PPC_RLWIMI'?
> >
> > PPC_RAW_LI() was added by commit 3a1812379163 ("powerpc/ppc-opcode:
> > Consolidate powerpc instructions from bpf_jit.h")
> >
> > Priori to that you have to use PPC_LI() instead, with the same arguments.
>
> I think that I forgot to reply: I've pushed a fixed patch resolved as
> proposed above.

Thanks, I'll go push out new -rc for 4.19 and 5.4 now.

greg k-h

\
 
 \ /
  Last update: 2021-10-12 08:42    [W:0.094 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site