lkml.org 
[lkml]   [2021]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH memcg] mm/page_alloc.c: avoid statistic update with 0
Vasily Averin writes:
>Yes, it's not a bug, it just makes the kernel a bit more efficient in a very unlikely case.
>However, it looks strange and makes uninformed code reviewers like me worry about possible
>problems inside the affected functions. No one else calls these functions from 0.

This statement is meaningless without data. If you have proof that it makes the
kernel more efficient, then please provide the profiles.

As it is I'd be surprised if this improved things. Either the code is hot
enough that the additional branch is cumbersome, or it's cold enough that it
doesn't even matter.

\
 
 \ /
  Last update: 2021-10-12 14:02    [W:2.064 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site