Messages in this thread | | | Date | Tue, 12 Oct 2021 12:33:46 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] soc: imx: imx8m-blk-ctrl: off by one in imx8m_blk_ctrl_xlate() |
| |
On Tue, Oct 12, 2021 at 10:29:27AM +0200, Lucas Stach wrote: > Hi Dan, > > Am Montag, dem 11.10.2021 um 15:36 +0300 schrieb Dan Carpenter: > > The > comparison should be >= to prevent reading one element beyond the > > end of the array. The onecell_data->domains[] array is allocated in > > imx8m_blk_ctrl_probe() and it has "onecell_data->num_domains" elements. > > Thanks for the patch! I guess this was found via smatch? I should > really make it a habit to use smatch on my submissions...
Yeah, but not a from a published check. I have a private check for off by one errors that warns about any > vs >= comparisons that cannot be proved as correct.
regards, dan carpenter
| |