Messages in this thread | | | Date | Tue, 12 Oct 2021 09:32:49 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT |
| |
On Mon, Oct 11, 2021 at 03:31:57PM +0530, Sandeep Maheswaram wrote: > dwc3 manages PHY by own DRD driver, so skip the management by > HCD core. > During runtime suspend phy was not getting suspend because > runtime_usage value is 2. > > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org> > --- > drivers/usb/dwc3/host.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c > index f29a264..0921f05 100644 > --- a/drivers/usb/dwc3/host.c > +++ b/drivers/usb/dwc3/host.c > @@ -11,6 +11,11 @@ > #include <linux/platform_device.h> > > #include "core.h" > +#include "../host/xhci-plat.h"
Why are you tying the dwc3 driver to the xhci driver?
> + > +static const struct xhci_plat_priv xhci_plat_dwc3_xhci = { > + .quirks = XHCI_SKIP_PHY_INIT,
If these quirks are now "global", they should go into a include/linux/usb/ .h file, right?
thanks,
greg k-h
| |