lkml.org 
[lkml]   [2021]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] init: Make unknown command line param message clearer
From
Date
On 10/12/21 5:01 PM, Steven Rostedt wrote:
> On Tue, 12 Oct 2021 16:35:23 -0500
> Andrew Halaney <ahalaney@redhat.com> wrote:
>
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -925,6 +925,10 @@ static void __init print_unknown_bootoptions(void)
>> for (p = &envp_init[2]; *p; p++)
>> end += sprintf(end, " %s", *p);
>>
>> + pr_notice("The kernel command line has unknown parameters. They are either\n");
>> + pr_notice("misspelled, not valid for the current kernel configuration,\n");
>> + pr_notice("or are meant for init but are not after the '--' delineator. They will\n");
>> + pr_notice("be passed to init along with those after '--' on the command line.\n");
>> pr_notice("Unknown command line parameters:%s\n", unknown_options);
>> memblock_free(unknown_options, len);
>
> What about just changing it to simply say:
>
> pr_notice("Unknown kernel command line parameters "%s", will be passed to user space.\n",
> unknown_options);
>

Yes, that's much more palatable.

thanks.
--
~Randy

\
 
 \ /
  Last update: 2021-10-13 02:18    [W:0.090 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site