lkml.org 
[lkml]   [2021]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/7] tty: serial: samsung_tty: Support runtime PM
    From
    Date
    On 11/10/2021 07:32, Hector Martin wrote:
    >>> +
    >>> s3c24xx_serial_cpufreq_deregister(to_ourport(port));
    >>> uart_remove_one_port(&s3c24xx_uart_drv, port);
    >>> +
    >>> + pm_runtime_disable(&dev->dev);
    >>
    >> Why disabling it only if port!=NULL? Can remove() be called if
    >> platform_set_drvdata() was not?
    >
    > Good question, I'm not entirely sure why these code paths have a check
    > for NULL there. They were already there, do you happen to know why? To
    > me it sounds like remove would only be called if probe succeeds, at
    > which point drvdata should always be set.
    >

    Exactly, anyway it is not part of your patch, so no problem.


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2021-10-11 08:49    [W:6.675 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site