lkml.org 
[lkml]   [2021]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 104/151] drm/nouveau/kms/nv50-: fix file release memory leak
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit 0b3d4945cc7e7ea1acd52cb06dfa83bfe265b6d5 ]

    When using single_open() for opening, single_release() should be
    called, otherwise the 'op' allocated in single_open() will be leaked.

    Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Reviewed-by: Karol Herbst <kherbst@redhat.com>
    Signed-off-by: Karol Herbst <kherbst@redhat.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210911075023.3969054-1-yangyingliang@huawei.com
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c
    index b8c31b697797..66f32d965c72 100644
    --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c
    +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c
    @@ -704,6 +704,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = {
    .open = nv50_crc_debugfs_flip_threshold_open,
    .read = seq_read,
    .write = nv50_crc_debugfs_flip_threshold_set,
    + .release = single_release,
    };

    int nv50_head_crc_late_register(struct nv50_head *head)
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-10-11 16:10    [W:4.116 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site