lkml.org 
[lkml]   [2021]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 086/151] netfs: Fix READ/WRITE confusion when calling iov_iter_xarray()
    Date
    From: David Howells <dhowells@redhat.com>

    [ Upstream commit 330de47d14af0c3995db81cc03cf5ca683d94d81 ]

    Fix netfs_clear_unread() to pass READ to iov_iter_xarray() instead of WRITE
    (the flag is about the operation accessing the buffer, not what sort of
    access it is doing to the buffer).

    Fixes: 3d3c95046742 ("netfs: Provide readahead and readpage netfs helpers")
    Signed-off-by: David Howells <dhowells@redhat.com>
    Reviewed-by: Jeff Layton <jlayton@kernel.org>
    cc: linux-cachefs@redhat.com
    cc: linux-afs@lists.infradead.org
    cc: ceph-devel@vger.kernel.org
    cc: linux-cifs@vger.kernel.org
    cc: linux-nfs@vger.kernel.org
    cc: v9fs-developer@lists.sourceforge.net
    cc: linux-fsdevel@vger.kernel.org
    cc: linux-mm@kvack.org
    Link: https://lore.kernel.org/r/162729351325.813557.9242842205308443901.stgit@warthog.procyon.org.uk/
    Link: https://lore.kernel.org/r/162886603464.3940407.3790841170414793899.stgit@warthog.procyon.org.uk
    Link: https://lore.kernel.org/r/163239074602.1243337.14154704004485867017.stgit@warthog.procyon.org.uk
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/netfs/read_helper.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/netfs/read_helper.c b/fs/netfs/read_helper.c
    index 0b6cd3b8734c..994ec22d4040 100644
    --- a/fs/netfs/read_helper.c
    +++ b/fs/netfs/read_helper.c
    @@ -150,7 +150,7 @@ static void netfs_clear_unread(struct netfs_read_subrequest *subreq)
    {
    struct iov_iter iter;

    - iov_iter_xarray(&iter, WRITE, &subreq->rreq->mapping->i_pages,
    + iov_iter_xarray(&iter, READ, &subreq->rreq->mapping->i_pages,
    subreq->start + subreq->transferred,
    subreq->len - subreq->transferred);
    iov_iter_zero(iov_iter_count(&iter), &iter);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-10-11 16:09    [W:5.330 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site