Messages in this thread | | | From | Anup Patel <> | Date | Mon, 11 Oct 2021 20:22:25 +0530 | Subject | Re: [PATCH 2/2] dt-bindings: update riscv plic claim-mask-support property |
| |
On Mon, Oct 11, 2021 at 6:54 PM <guoren@kernel.org> wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > Add claim-mask-support to control riscv,plic don't call > unnecessary mask/unmask operations. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Palmer Dabbelt <palmerdabbelt@google.com> > Cc: Anup Patel <anup@brainfault.org> > Cc: Atish Patra <atish.patra@wdc.com> > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 08d5a57ce00f..f32c1792604c 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -71,6 +71,8 @@ properties: > description: > Specifies how many external interrupts are supported by this controller. > > + claim-mask-support: true > +
This DT property does not describe HW in any way, rather it enable/disable a SW behaviour in the driver. IMO, this DT property should not be added.
Regards, Anup
> required: > - compatible > - '#address-cells' > -- > 2.25.1 >
| |