lkml.org 
[lkml]   [2021]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v4 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.
    Date
    On 10/10/21 3:09 PM, Eugene Shalygin wrote:
    >> Changes in v4:
    >> - implement wmi driver instead platform driver.
    >
    > There are many ASUS boards where the required function is present but
    > does nothing. With the WMI module alias the driver will be attempted
    > to load for those boards (and rejected by the _probe() function). Is
    > it a good thing?
    >

    Drivers failing probe with -ENODEV (presumably here because dmi_check_system()
    does not find a match) is pretty normal. Board detection with the WMI driver
    seems much more straightforward/simple compared the previous version with
    the platform driver. Maybe I am missing something, but I don't see a
    problem with the WMI approach.

    Guenter

    \
     
     \ /
      Last update: 2021-10-11 01:52    [W:2.436 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site