Messages in this thread | | | Date | Sun, 10 Oct 2021 18:19:46 +0100 | From | Andre Przywara <> | Subject | Re: [PATCH] bus: sun50i-de2: Adjust printing error message |
| |
On Sun, 10 Oct 2021 09:18:12 +0200 Jernej Skrabec <jernej.skrabec@gmail.com> wrote:
> SRAM driver often returns -EPROBE_DEFER and thus this bus driver often > prints error message, even if it probes successfully later. This is > confusing for users and they often think that something is wrong. > > Use dev_err_probe() helper for printing error message. It handles > -EPROBE_DEFER automatically.
Ah, many thanks for just fixing this, it was indeed confusing people. And thanks for pointing to this useful helper!
Would this actually be a candidate for stable?
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers, Andre
> --- > drivers/bus/sun50i-de2.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/sun50i-de2.c b/drivers/bus/sun50i-de2.c > index 672518741f86..414f29cdedf0 100644 > --- a/drivers/bus/sun50i-de2.c > +++ b/drivers/bus/sun50i-de2.c > @@ -15,10 +15,9 @@ static int sun50i_de2_bus_probe(struct platform_device *pdev) > int ret; > > ret = sunxi_sram_claim(&pdev->dev); > - if (ret) { > - dev_err(&pdev->dev, "Error couldn't map SRAM to device\n"); > - return ret; > - } > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "Couldn't map SRAM to device\n"); > > of_platform_populate(np, NULL, NULL, &pdev->dev); >
| |