lkml.org 
[lkml]   [2021]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4] spi: atmel: Fix PDC transfer setup bug
Date
Hi Ville,

On 9/21/21 12:21 AM, Ville Baillie wrote:
> Commit 5fa5e6dec762 ("spi: atmel: Switch to transfer_one transfer
> method") refactored the code and changed a conditional causing
> atmel_spi_dma_map_xfer to never be called in PDC mode. This causes the
> driver to silently fail.
>
> This patch changes the conditional to match the behaviour of the
> previous commit before the refactor.
>
> Signed-off-by: Ville Baillie <villeb@bytesnap.co.uk>
Shouldn't this have a FIXES tag?
> ---
> drivers/spi/spi-atmel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 788dcdf25f00..f872cf196c2f 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1301,7 +1301,7 @@ static int atmel_spi_one_transfer(struct spi_master *master,
> * DMA map early, for performance (empties dcache ASAP) and
> * better fault reporting.
> */
> - if ((!master->cur_msg_mapped)
> + if ((!master->cur_msg->is_dma_mapped)
> && as->use_pdc) {
> if (atmel_spi_dma_map_xfer(as, xfer) < 0)
> return -ENOMEM;
> @@ -1381,7 +1381,7 @@ static int atmel_spi_one_transfer(struct spi_master *master,
> }
> }
>
> - if (!master->cur_msg_mapped
> + if (!master->cur_msg->is_dma_mapped
> && as->use_pdc)
> atmel_spi_dma_unmap_xfer(master, xfer);
>
>

Regards,
Dan
\
 
 \ /
  Last update: 2021-10-01 23:13    [W:0.096 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site