Messages in this thread | | | Date | Fri, 1 Oct 2021 11:20:36 +0200 | Subject | Re: [PATCH 1/3] net: phy: mscc: Add possibilty to disable combined LED mode | From | Frieder Schrempf <> |
| |
On 01.10.21 02:05, Andrew Lunn wrote: > On Thu, Sep 30, 2021 at 02:57:43PM +0200, Frieder Schrempf wrote: >> From: Frieder Schrempf <frieder.schrempf@kontron.de> >> >> By default the LED modes offer to combine two indicators like speed/link >> and activity in one LED. In order to use a LED only for the first of the >> two modes, the combined feature needs to be disabled. >> >> In order to do this we introduce a boolean devicetree property >> 'vsc8531,led-[N]-combine-disable' and wire it up to the matching >> bits in the LED behavior register. > > Sorry, but no DT property. Each PHY has its own magic combination of > DT properties, nothing shared, nothing common. This does not scale. > > Please look at the work being done to control PHY LEDs using the Linux > LED infrastructure. That should give us one uniform interface for all > PHY LEDs.
+Cc: Marek
I guess you are referring to this: [1]?
If so, the last version I could find is a year old now. Is anyone still working on this?
I understand, that the generic approach is the one we want to have, but does this really mean adding PHY led configuration via DT to existing drivers (that already use DT properties for LED modes) is not accepted anymore, even if the new API is not yet in place?
If anyone (Marek?) would be willing to revive this series, I could maybe try to find some spare time to rework the mscc PHY LED configuration on top of this and do some tests.
[1] https://patches.linaro.org/patch/255422/
| |