lkml.org 
[lkml]   [2021]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks
    Hi Adam,

    On Fri, Jan 8, 2021 at 3:11 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
    > On Mon, Dec 28, 2020 at 10:32 PM Adam Ford <aford173@gmail.com> wrote:
    > > The AVB driver assumes there is an external clock, but it could
    > > be driven by an external clock. In order to enable a programmable
    > > clock, it needs to be added to the clocks list and enabled in the
    > > driver. Since there currently only one clock, there is no
    > > clock-names list either.
    > >
    > > Update bindings to add the additional optional clock, and explicitly
    > > name both of them.
    > >
    > > Signed-off-by: Adam Ford <aford173@gmail.com>
    >
    > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

    Upon second look...

    >> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
    >> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
    >> @@ -49,7 +49,16 @@ properties:
    >> interrupt-names: true
    >>
    >> clocks:
    >> - maxItems: 1
    >> + minItems: 1
    >> + maxItems: 2
    >> + items:
    >> + - description: AVB functional clock
    >> + - description: Optional TXC reference clock
    >> +
    >> + clock-names:
    >> + items:
    >> + - const: fck
    >> + - const: txc_refclk

    On R-Car Gen3 and RZ/G2, RGMII is used, and this clock is called
    "txcrefclk", i.e. without underscore.
    On R-Car Gen2, GMII is used, and this clock is called "gtxrefclk".

    Perhaps it should just be called "refclk"?

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2021-01-08 15:27    [W:4.745 / U:1.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site