lkml.org 
[lkml]   [2021]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x
    On Wed, Dec 23, 2020 at 1:56 AM Andrew Lunn <andrew@lunn.ch> wrote:
    >
    > > + gpio-controller: true
    > > + "#gpio-cells":
    > > + const: 2
    > > +
    > > + qcom,single-led-1000:
    > > + description: |
    > > + If present, then dedicated 1000 Mbit will light up for 1000Base-T.
    > > + This is a workround for boards with a single LED instead of two.
    > > + type: boolean
    > > +
    > > + qcom,single-led-100:
    > > + description: |
    > > + If present, then dedicated 1000 Mbit will light up for 100Base-TX.
    > > + This is a workround for boards with a single LED instead of two.
    > > + type: boolean
    > > +
    > > + qcom,single-led-10:
    > > + description: |
    > > + If present, then dedicated 1000 Mbit will light up for 10Base-Te.
    > > + This is a workround for boards with a single LED instead of two.
    > > + type: boolean
    >
    > Sorry, but no. Please look at the work being done for allow PHY LEDs
    > to be controlled via the LED subsystem.

    Ok, I will drop the LED configuration from the driver until there is a generic
    way to do it.
    I was following the work on it, but it seems to have halted after September.
    >
    > > + qcom,tx-driver-strength:
    > > + description: PSGMII/QSGMII TX driver strength control.
    > > + $ref: /schemas/types.yaml#/definitions/uint32
    > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]
    >
    > Please use the actual values here, and have the driver convert to the
    > value poked into the register. So the property would be
    > qcom,tx-driver-strength-mv and it would have the value 220 for
    > example.
    Ok, it actually makes more sense than using dt-binding includes for this.
    >
    > > +
    > > + qcom,control-dac:
    > > + description: Analog MDI driver amplitude and bias current.
    > > + $ref: /schemas/types.yaml#/definitions/uint32
    > > + enum: [0, 1, 2, 3, 4, 5, 6, 7]
    >
    > Make here.
    I am using defines in dt-binding includes for this one as it makes the
    values humanly readable in DT as these configure the amplitude and
    bias current for power saving.
    >
    > Andrew

    \
     
     \ /
      Last update: 2021-01-07 17:41    [W:4.223 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site