Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH v2 5/5] usb: gadget: u_audio: clean up locking | Date | Thu, 07 Jan 2021 11:28:35 +0200 |
| |
Jerome Brunet <jbrunet@baylibre.com> writes:
> snd_pcm_stream_lock() is held when the ALSA .trigger() callback is called. > The lock of 'struct uac_rtd_params' is not necessary since all its locking > operation are done under the snd_pcm_stream_lock() too. > > Also, usb_request .complete() is called with irqs disabled, so saving and > restoring the irqs is not necessary. > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
This is nice!
Acked-by: Felipe Balbi <balbi@.kernel.org>
-- balbi [unhandled content-type:application/pgp-signature] | |