Messages in this thread | | | Subject | Re: [PATCH] rxrpc: fix handling of an unsupported token type in rxrpc_read() | From | Tom Rix <> | Date | Wed, 6 Jan 2021 12:38:44 -0800 |
| |
On 1/6/21 11:44 AM, David Howells wrote: > Tom Rix <trix@redhat.com> wrote: > >> These two loops iterate over the same data, i believe returning here is all >> that is needed. > But if the first loop is made to support a new type, but the second loop is > missed, it will then likely oops. Besides, the compiler should optimise both > paths together.
You are right, I was only considering the existing cases.
Tom
> David >
| |