Messages in this thread | | | Date | Wed, 6 Jan 2021 09:27:33 -0800 | From | Sean Christopherson <> | Subject | Re: [PATCH 4/6] KVM: nSVM: correctly restore nested_run_pending on migration |
| |
On Wed, Jan 06, 2021, Maxim Levitsky wrote: > The code to store it on the migration exists, but no code was restoring it. > > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com> > --- > arch/x86/kvm/svm/nested.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c > index 6208d3a5a3fdb..c1a3d0e996add 100644 > --- a/arch/x86/kvm/svm/nested.c > +++ b/arch/x86/kvm/svm/nested.c > @@ -1203,6 +1203,10 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu, > * in the registers, the save area of the nested state instead > * contains saved L1 state. > */ > + > + if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING) > + svm->nested.nested_run_pending = true;
This should be:
svm->nested.nested_run_pending = !!(kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING);
> + > copy_vmcb_control_area(&hsave->control, &svm->vmcb->control); > hsave->save = *save; > > -- > 2.26.2 >
| |