lkml.org 
[lkml]   [2021]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 24/47] scsi: cxgb4i: Fix TLS dependency
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    commit cb5253198f10a4cd79b7523c581e6173c7d49ddb upstream.

    SCSI_CXGB4_ISCSI selects CHELSIO_T4. The latter depends on TLS || TLS=n, so
    since 'select' does not check dependencies of the selected symbol,
    SCSI_CXGB4_ISCSI should also depend on TLS || TLS=n.

    This prevents the following kconfig warning and restricts SCSI_CXGB4_ISCSI
    to 'm' whenever TLS=m.

    WARNING: unmet direct dependencies detected for CHELSIO_T4
    Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_CHELSIO [=y] && PCI [=y] && (IPV6 [=y] || IPV6 [=y]=n) && (TLS [=m] || TLS [=m]=n)
    Selected by [y]:
    - SCSI_CXGB4_ISCSI [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && PCI [=y] && INET [=y] && (IPV6 [=y] || IPV6 [=y]=n) && ETHERNET [=y]

    Link: https://lore.kernel.org/r/20201208220505.24488-1-rdunlap@infradead.org
    Fixes: 7b36b6e03b0d ("[SCSI] cxgb4i v5: iscsi driver")
    Cc: Karen Xie <kxie@chelsio.com>
    Cc: linux-scsi@vger.kernel.org
    Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
    Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/cxgbi/cxgb4i/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/scsi/cxgbi/cxgb4i/Kconfig
    +++ b/drivers/scsi/cxgbi/cxgb4i/Kconfig
    @@ -4,6 +4,7 @@ config SCSI_CXGB4_ISCSI
    depends on PCI && INET && (IPV6 || IPV6=n)
    depends on THERMAL || !THERMAL
    depends on ETHERNET
    + depends on TLS || TLS=n
    select NET_VENDOR_CHELSIO
    select CHELSIO_T4
    select CHELSIO_LIB

    \
     
     \ /
      Last update: 2021-01-04 17:11    [W:5.614 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site