lkml.org 
[lkml]   [2021]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency
    Hi Jiaxun,

    On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
    > Goldfish platform is covered with dust.
    > However the goldfish-rtc had been used as virtualized RTC
    > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
    > we can drop other parts of goldfish but leave goldfish-rtc here.
    >
    > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

    Thanks for your patch!

    > --- a/drivers/rtc/Kconfig
    > +++ b/drivers/rtc/Kconfig
    > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
    > config RTC_DRV_GOLDFISH
    > tristate "Goldfish Real Time Clock"
    > depends on OF && HAS_IOMEM
    > - depends on GOLDFISH || COMPILE_TEST
    > help
    > Say yes to enable RTC driver for the Goldfish based virtual platform.

    I was just looking to see if someone had already sent a patch to add
    "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
    noticed your patch had removed it...

    What about

    depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST

    instead?

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2021-01-04 14:32    [W:3.910 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site