Messages in this thread | | | From | Andy Lutomirski <> | Date | Sat, 30 Jan 2021 18:57:58 -0800 | Subject | Re: [RFC 01/20] mm/tlb: fix fullmm semantics |
| |
On Sat, Jan 30, 2021 at 5:19 PM Nadav Amit <nadav.amit@gmail.com> wrote: > > > On Jan 30, 2021, at 5:02 PM, Andy Lutomirski <luto@kernel.org> wrote: > > > > On Sat, Jan 30, 2021 at 4:16 PM Nadav Amit <nadav.amit@gmail.com> wrote: > >> From: Nadav Amit <namit@vmware.com> > >> > >> fullmm in mmu_gather is supposed to indicate that the mm is torn-down > >> (e.g., on process exit) and can therefore allow certain optimizations. > >> However, tlb_finish_mmu() sets fullmm, when in fact it want to say that > >> the TLB should be fully flushed. > > > > Maybe also rename fullmm? > > Possible. How about mm_torn_down?
Sure. Or mm_exiting, perhaps?
> > I should have also changed the comment in tlb_finish_mmu().
| |