Messages in this thread | | | Subject | Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver | From | Jason Wang <> | Date | Mon, 4 Jan 2021 11:28:05 +0800 |
| |
On 2020/12/4 下午11:20, Stefano Garzarella wrote: >> +#define VP_VDPA_QUEUE_MAX 256 >> +#define VP_VDPA_DRIVER_NAME "vp_vdpa" >> + >> +struct vp_vring { >> + void __iomem *notify; >> + char msix_name[256]; > > Can we use a macro for the msix_name size, since we use 256 in > multiple places?
Yes, will switch to use a macro.
> >> + struct vdpa_callback cb; >> + int irq; >> +}; >> + >> +struct vp_vdpa { >> + struct vdpa_device vdpa; >> + struct virtio_pci_modern_device mdev; >> + struct vp_vring *vring; >> + struct vdpa_callback cb; > ^ > It is not relevant, but 'config_cb' is maybe clearer to read. >
Will change to config_cb.
> The rest looks good.
Thanks
> > Thanks, > Stefano
| |