lkml.org 
[lkml]   [2021]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] pcmcia: Switch to using the new API kobj_to_dev()
    Date
    fixed the following coccicheck:
    drivers/pcmcia/cistpl.c:1557:54-55: WARNING opportunity for kobj_to_dev()
    drivers/pcmcia/cistpl.c:1584:53-54: WARNING opportunity for kobj_to_dev()

    Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
    ---
    drivers/pcmcia/cistpl.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c
    index cf109d9..e693910 100644
    --- a/drivers/pcmcia/cistpl.c
    +++ b/drivers/pcmcia/cistpl.c
    @@ -1554,7 +1554,7 @@ static ssize_t pccard_show_cis(struct file *filp, struct kobject *kobj,
    if (off + count > size)
    count = size - off;

    - s = to_socket(container_of(kobj, struct device, kobj));
    + s = to_socket(kobj_to_dev(kobj));

    if (!(s->state & SOCKET_PRESENT))
    return -ENODEV;
    @@ -1581,7 +1581,7 @@ static ssize_t pccard_store_cis(struct file *filp, struct kobject *kobj,
    if (error)
    return error;

    - s = to_socket(container_of(kobj, struct device, kobj));
    + s = to_socket(kobj_to_dev(kobj));

    if (off)
    return -EINVAL;
    --
    2.7.4
    \
     
     \ /
      Last update: 2021-01-04 03:01    [W:3.351 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site