Messages in this thread | | | Subject | Re: [PATCH] platform/surface: mark PM functions as __maybe_unused | From | Maximilian Luz <> | Date | Sun, 3 Jan 2021 16:33:37 +0100 |
| |
On 1/3/21 3:04 PM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When CONFIG_PM is disabled, the compiler produces harmless warnings: > > drivers/platform/surface/surface_gpe.c:184:12: error: unused function 'surface_gpe_suspend' [-Werror,-Wunused-function] > static int surface_gpe_suspend(struct device *dev) > drivers/platform/surface/surface_gpe.c:189:12: error: unused function 'surface_gpe_resume' [-Werror,-Wunused-function] > static int surface_gpe_resume(struct device *dev) > > Mark these as __maybe_unused to shut up the warning. > > Fixes: 274335f1c557 ("platform/surface: Add Driver to set up lid GPEs on MS Surface device") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/platform/surface/surface_gpe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c > index e49e5d6d5d4e..86f6991b1215 100644 > --- a/drivers/platform/surface/surface_gpe.c > +++ b/drivers/platform/surface/surface_gpe.c > @@ -181,12 +181,12 @@ static int surface_lid_enable_wakeup(struct device *dev, bool enable) > return 0; > } > > -static int surface_gpe_suspend(struct device *dev) > +static int __maybe_unused surface_gpe_suspend(struct device *dev) > { > return surface_lid_enable_wakeup(dev, true); > } > > -static int surface_gpe_resume(struct device *dev) > +static int __maybe_unused surface_gpe_resume(struct device *dev) > { > return surface_lid_enable_wakeup(dev, false); > } >
Hi,
a patch doing this exact thing has already been submitted, but has yet to be picked up:
https://www.spinics.net/lists/platform-driver-x86/msg23888.html
Thanks, Max
| |