Messages in this thread | | | From | Andrey Konovalov <> | Date | Fri, 29 Jan 2021 19:09:00 +0100 | Subject | Re: [PATCH v9 3/4] kasan: Add report for async mode |
| |
On Fri, Jan 29, 2021 at 6:56 PM Vincenzo Frascino <vincenzo.frascino@arm.com> wrote: > > Hi Andrey, > > On 1/29/21 5:40 PM, Andrey Konovalov wrote: > > I suggest to call end_report(&flags, 0) here and check addr !=0 in > > end_report() before calling trace_error_report_end(). > > > > Probably this is better as: > > if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS)) > > Because that condition passes always addr == 0.
Not sure I understand. Call report_end(&flags, 0) and then there do:
if (addr) trace_error_report_end(...);
Although maybe it makes sense to still trace all async bugs to address 0. Or to some magic address.
Alex, WDYT?
| |