Messages in this thread | | | Date | Thu, 28 Jan 2021 11:39:23 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH] kernfs: Remove redundant code |
| |
On Thu, Jan 28, 2021 at 04:25:32PM +0800, Abaci Team wrote: > Fix the following coccicheck warnings: > > ./fs/kernfs/file.c:647:1-3: WARNING: possible condition with no effect > (if == else). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Suggested-by: Jiapeng Zhong <oswb@linux.alibaba.com> > Signed-off-by: Abaci Team <abaci-bugfix@linux.alibaba.com> > --- > fs/kernfs/file.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c > index c757193..9a74c9d 100644 > --- a/fs/kernfs/file.c > +++ b/fs/kernfs/file.c > @@ -644,11 +644,7 @@ static int kernfs_fop_open(struct inode *inode, struct file *file) > * Both paths of the branch look the same. They're supposed to > * look that way and give @of->mutex different static lockdep keys.
Please read the comment right above.
Thanks.
-- tejun
| |