Messages in this thread | | | Date | Thu, 28 Jan 2021 17:09:57 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 13/13] module: remove EXPORY_UNUSED_SYMBOL* |
| |
On Wed, Jan 27, 2021 at 02:49:38PM +0100, Jessica Yu wrote: >> #ifdef CONFIG_MODULE_SIG >> /* Signature was verified. */ >> bool sig_ok; >> @@ -592,7 +580,6 @@ struct symsearch { >> GPL_ONLY, >> WILL_BE_GPL_ONLY, >> } license; >> - bool unused; >> };
> Thanks for the cleanups. While we're here, I noticed that struct > symsearch is only used internally in kernel/module.c, so I don't think > it actually needs to be in include/linux/module.h. I don't see it used > anywhere else. We could move maybe that to kernel/module-internal.h.
I've added a patch to just move it directly into module.c.
| |