lkml.org 
[lkml]   [2021]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/12] thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/thunderbolt/switch.c:540: warning: Function parameter or member 'port' not described in 'tb_wait_for_port'
    drivers/thunderbolt/switch.c:540: warning: Function parameter or member 'wait_if_unplugged' not described in 'tb_wait_for_port'
    drivers/thunderbolt/switch.c:599: warning: Function parameter or member 'port' not described in 'tb_port_add_nfc_credits'
    drivers/thunderbolt/switch.c:599: warning: Function parameter or member 'credits' not described in 'tb_port_add_nfc_credits'
    drivers/thunderbolt/switch.c:653: warning: Function parameter or member 'port' not described in 'tb_port_clear_counter'
    drivers/thunderbolt/switch.c:653: warning: Function parameter or member 'counter' not described in 'tb_port_clear_counter'
    drivers/thunderbolt/switch.c:730: warning: Function parameter or member 'port' not described in 'tb_init_port'
    drivers/thunderbolt/switch.c:1348: warning: Function parameter or member 'sw' not described in 'tb_plug_events_active'
    drivers/thunderbolt/switch.c:1348: warning: Function parameter or member 'active' not described in 'tb_plug_events_active'
    drivers/thunderbolt/switch.c:2654: warning: Function parameter or member 'sw' not described in 'tb_sw_set_unplugged'

    Cc: Andreas Noever <andreas.noever@gmail.com>
    Cc: Michael Jamet <michael.jamet@intel.com>
    Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
    Cc: Yehezkel Bernat <YehezkelShB@gmail.com>
    Cc: linux-usb@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/thunderbolt/switch.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
    index cdba05e72486b..ce1b120d1cd46 100644
    --- a/drivers/thunderbolt/switch.c
    +++ b/drivers/thunderbolt/switch.c
    @@ -523,7 +523,7 @@ int tb_port_state(struct tb_port *port)
    return phy.state;
    }

    -/**
    +/*
    * tb_wait_for_port() - wait for a port to become ready
    *
    * Wait up to 1 second for a port to reach state TB_PORT_UP. If
    @@ -587,7 +587,7 @@ int tb_wait_for_port(struct tb_port *port, bool wait_if_unplugged)
    return 0;
    }

    -/**
    +/*
    * tb_port_add_nfc_credits() - add/remove non flow controlled credits to port
    *
    * Change the number of NFC credits allocated to @port by @credits. To remove
    @@ -644,7 +644,7 @@ int tb_port_set_initial_credits(struct tb_port *port, u32 credits)
    return tb_port_write(port, &data, TB_CFG_PORT, ADP_CS_5, 1);
    }

    -/**
    +/*
    * tb_port_clear_counter() - clear a counter in TB_CFG_COUNTER
    *
    * Return: Returns 0 on success or an error code on failure.
    @@ -718,7 +718,7 @@ int tb_port_disable(struct tb_port *port)
    return __tb_port_enable(port, false);
    }

    -/**
    +/*
    * tb_init_port() - initialize a port
    *
    * This is a helper method for tb_switch_alloc. Does not check or initialize
    @@ -1337,7 +1337,7 @@ int tb_switch_reset(struct tb_switch *sw)
    return res.err;
    }

    -/**
    +/*
    * tb_plug_events_active() - enable/disable plug events on a switch
    *
    * Also configures a sane plug_events_delay of 255ms.
    @@ -2647,7 +2647,7 @@ void tb_switch_remove(struct tb_switch *sw)
    device_unregister(&sw->dev);
    }

    -/**
    +/*
    * tb_sw_set_unplugged() - set is_unplugged on switch and downstream switches
    */
    void tb_sw_set_unplugged(struct tb_switch *sw)
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-01-27 12:42    [W:4.167 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site