Messages in this thread | | | From | Gabriel Krisman Bertazi <> | Subject | Re: [PATCH] ptrace: restore the previous single step reporting behavior | Date | Wed, 27 Jan 2021 20:55:20 -0300 |
| |
Yuxuan Shui <yshuiv7@gmail.com> writes:
> Commit 64eb35f701f04b30706e21d1b02636b5d31a37d2 changed when single step > is reported. > > Specifically, the report_single_step is changed so that single steps are > only reported when both SYSCALL_EMU and _TIF_SINGLESTEP are set, while > previously they are reported when _TIF_SINGLESTEP is set without > _TIF_SYSCALL_EMU being set. > > This behavior change breaks rr [1] > > This commit restores the old behavior. > > [1]: https://github.com/rr-debugger/rr/issues/2793 > > Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Looks correct to me.
To gather the right attention, you should directly CC the correct maintainers.
Fixes: 64eb35f701f0 ("ptrace: Migrate TIF_SYSCALL_EMU to use SYSCALL_WORK flag") Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
-- Gabriel Krisman Bertazi
| |