Messages in this thread | | | From | Andrii Nakryiko <> | Date | Wed, 27 Jan 2021 12:58:15 -0800 | Subject | Re: [PATCH bpf-next v6 3/5] selftests/bpf: Integrate the socket_cookie test to test_progs |
| |
On Tue, Jan 26, 2021 at 10:36 AM Florent Revest <revest@chromium.org> wrote: > > Currently, the selftest for the BPF socket_cookie helpers is built and > run independently from test_progs. It's easy to forget and hard to > maintain. > > This patch moves the socket cookies test into prog_tests/ and vastly > simplifies its logic by: > - rewriting the loading code with BPF skeletons > - rewriting the server/client code with network helpers > - rewriting the cgroup code with test__join_cgroup > - rewriting the error handling code with CHECKs > > Signed-off-by: Florent Revest <revest@chromium.org> > Acked-by: KP Singh <kpsingh@kernel.org> > ---
LGTM.
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> tools/testing/selftests/bpf/.gitignore | 1 - > tools/testing/selftests/bpf/Makefile | 3 +- > .../selftests/bpf/prog_tests/socket_cookie.c | 71 ++++++ > .../selftests/bpf/progs/socket_cookie_prog.c | 2 - > .../selftests/bpf/test_socket_cookie.c | 208 ------------------ > 5 files changed, 72 insertions(+), 213 deletions(-) > create mode 100644 tools/testing/selftests/bpf/prog_tests/socket_cookie.c > delete mode 100644 tools/testing/selftests/bpf/test_socket_cookie.c >
[...]
| |