lkml.org 
[lkml]   [2021]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 080/199] pinctrl: mediatek: Fix fallback call path
    Date
    From: Hsin-Yi Wang <hsinyi@chromium.org>

    [ Upstream commit 81bd1579b43e0e285cba667399f1b063f1ce7672 ]

    Some SoCs, eg. mt8183, are using a pinconfig operation bias_set_combo.
    The fallback path in mtk_pinconf_adv_pull_set() should also try this
    operation.

    Fixes: cafe19db7751 ("pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage")
    Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
    Acked-by: Sean Wang <sean.wang@kernel.org>
    Link: https://lore.kernel.org/r/20201228090425.2130569-1-hsinyi@chromium.org
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
    index 7e950f5d62d0f..7815426e7aeaa 100644
    --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
    +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
    @@ -926,6 +926,10 @@ int mtk_pinconf_adv_pull_set(struct mtk_pinctrl *hw,
    err = hw->soc->bias_set(hw, desc, pullup);
    if (err)
    return err;
    + } else if (hw->soc->bias_set_combo) {
    + err = hw->soc->bias_set_combo(hw, desc, pullup, arg);
    + if (err)
    + return err;
    } else {
    return -ENOTSUPP;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-01-26 10:37    [W:4.221 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site