Messages in this thread | | | Date | Tue, 26 Jan 2021 22:17:23 +0100 | From | Oliver Graute <> | Subject | Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD |
| |
On 26/01/21, Fabio Estevam wrote: > Hi Oliver, > > On Mon, Jan 25, 2021 at 7:17 PM Oliver Graute <oliver.graute@gmail.com> wrote: > > > I would prefer mine, because I got a wrong colored penguin on bootup > > with yours :-)
The wrong colored Tux is caused by the bus_format:
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
So I assume I need another bus_format here.
> > I have originally passed .bpc = 8, but looking at the panel datasheet, > this should be: > .bpc = 6 instead.
yes this is right. I found it too in the datasheet. I'll fix it in next version of the patch. > > In your patch, you pass the timing parameters three times, but they > are all the same. > > Usually, it is meant to be: minimal, typical, maximum values.
yes because on a lot of entries there is just the typical value and no min and max. But not on all of them.
Best regards,
Oliver
| |