lkml.org 
[lkml]   [2021]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] kernel/dma: remove unnecessary unmap_kernel_range
    On Tue, Jan 26, 2021 at 02:54:01PM +1000, Nicholas Piggin wrote:
    > vunmap will remove ptes.

    Should there be some ASSERT after the vunmap to make sure that is the
    case?
    >
    > Cc: Christoph Hellwig <hch@lst.de>
    > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
    > Cc: Robin Murphy <robin.murphy@arm.com>
    > Cc: iommu@lists.linux-foundation.org
    > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
    > ---
    > kernel/dma/remap.c | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c
    > index 905c3fa005f1..b4526668072e 100644
    > --- a/kernel/dma/remap.c
    > +++ b/kernel/dma/remap.c
    > @@ -66,6 +66,5 @@ void dma_common_free_remap(void *cpu_addr, size_t size)
    > return;
    > }
    >
    > - unmap_kernel_range((unsigned long)cpu_addr, PAGE_ALIGN(size));
    > vunmap(cpu_addr);
    > }
    > --
    > 2.23.0
    >
    > _______________________________________________
    > iommu mailing list
    > iommu@lists.linux-foundation.org
    > https://lists.linuxfoundation.org/mailman/listinfo/iommu

    \
     
     \ /
      Last update: 2021-01-27 04:42    [W:3.535 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site