Messages in this thread | | | Subject | Re: [PATCHv3 4/6] fpga: of-fpga-region: add authenticate-fpga-config property | From | Richard Gong <> | Date | Tue, 26 Jan 2021 08:03:40 -0600 |
| |
Hi Moritz,
On 1/25/21 11:10 PM, Moritz Fischer wrote: > On Mon, Jan 25, 2021 at 02:56:26PM -0600, richard.gong@linux.intel.com wrote: >> From: Richard Gong <richard.gong@intel.com> >> >> Add authenticate-fpga-config property to support FPGA bitstream >> authentication, which makes sure a signed bitstream has valid signatures. >> >> Signed-off-by: Richard Gong <richard.gong@intel.com> >> --- >> v3: no change >> v2: changed in alphabetical order >> --- >> drivers/fpga/of-fpga-region.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c >> index e405309..3840883 100644 >> --- a/drivers/fpga/of-fpga-region.c >> +++ b/drivers/fpga/of-fpga-region.c >> @@ -219,6 +219,9 @@ static struct fpga_image_info *of_fpga_region_parse_ov( >> info->overlay = overlay; >> >> /* Read FPGA region properties from the overlay */ >> + if (of_property_read_bool(overlay, "authenticate-fpga-config")) >> + info->flags |= FPGA_MGR_BITSTREM_AUTHENTICATION; >> + > Should you check here that no new nodes are being added as you *only* > authenticate?
Sure, I will add additional checks in next submission.
> >> if (of_property_read_bool(overlay, "partial-fpga-config")) >> info->flags |= FPGA_MGR_PARTIAL_RECONFIG; >> >> -- >> 2.7.4 >> > > Thanks, > Moritz > Regards, Richard
| |