Messages in this thread | | | Date | Mon, 25 Jan 2021 08:49:09 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/3] blk-mq: Always complete remote completions requests in softirq |
| |
On Mon, Jan 25, 2021 at 08:23:03AM +0000, Christoph Hellwig wrote: > On Sat, Jan 23, 2021 at 09:10:26PM +0100, Sebastian Andrzej Siewior wrote: > > Controllers with multiple queues have their IRQ-handelers pinned to a > > CPU. The core shouldn't need to complete the request on a remote CPU. > > > > Remove this case and always raise the softirq to complete the request. > > What about changing blk_mq_trigger_softirq to take a void * argument > and thus removing __blk_mq_complete_request_remote entirely?
I'll take this back - that change is in the way of what you do in patch 3. So this looks good as-is:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |