Messages in this thread | | | Date | Fri, 22 Jan 2021 20:12:30 -0800 (PST) | Subject | Re: [PATCH v15 03/11] riscv/Kconfig: make direct map manipulation options depend on MMU | From | Palmer Dabbelt <> |
| |
On Wed, 20 Jan 2021 10:06:04 PST (-0800), rppt@kernel.org wrote: > From: Mike Rapoport <rppt@linux.ibm.com> > > ARCH_HAS_SET_DIRECT_MAP and ARCH_HAS_SET_MEMORY configuration options have > no meaning when CONFIG_MMU is disabled and there is no point to enable them > for the nommu case. > > Add an explicit dependency on MMU for these options. > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > Reported-by: kernel test robot <lkp@intel.com> > --- > arch/riscv/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index d82303dcc6b6..d35ce19ab1fa 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -25,8 +25,8 @@ config RISCV > select ARCH_HAS_KCOV > select ARCH_HAS_MMIOWB > select ARCH_HAS_PTE_SPECIAL > - select ARCH_HAS_SET_DIRECT_MAP > - select ARCH_HAS_SET_MEMORY > + select ARCH_HAS_SET_DIRECT_MAP if MMU > + select ARCH_HAS_SET_MEMORY if MMU > select ARCH_HAS_STRICT_KERNEL_RWX if MMU > select ARCH_OPTIONAL_KERNEL_RWX if ARCH_HAS_STRICT_KERNEL_RWX > select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT
Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
LMK if you want this to go in via the RISC-V tree, otherwise I'm going to assume it's going in along with the rest of these. FWIW I see these in other architectures without the MMU guard.
Thanks!
| |