Messages in this thread | | | Subject | Re: [PATCH v2 4/5] hugetlb: convert PageHugeTemporary() to HPageTemporary flag | From | Mike Kravetz <> | Date | Wed, 20 Jan 2021 10:14:30 -0800 |
| |
On 1/20/21 2:09 AM, Oscar Salvador wrote: > On Tue, Jan 19, 2021 at 05:30:48PM -0800, Mike Kravetz wrote: >> Use new hugetlb specific HPageTemporary flag to replace the >> PageHugeTemporary() interfaces. >> >> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> > > I would have added a brief comment explaining why it is ok to drop > the PageHuge() check in PageHugeTemporary. > AFAICS, the paths checking it already know they are handling with a > hugetlb page, but still it is better to mention it in the changelog > in case someone wonders.
Thanks.
Since I have to do another version, I will add this.
-- Mike Kravetz
| |