Messages in this thread | | | Date | Tue, 19 Jan 2021 13:11:22 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver |
| |
On Tue, Jan 19, 2021 at 10:56:17AM +0000, Kieran Bingham wrote: > On 18/01/2021 00:34, Daniel Scally wrote:
...
> > +config INTEL_SKL_INT3472 > > + tristate "Intel SkyLake ACPI INT3472 Driver" > > + depends on X86 && ACPI > > + select REGMAP_I2C > > I've tried compiling this as a built in and a module and on my minimal > config I had failures on both for regulator_register and > regulator_unregister. > > I suspect this needs to have either a selects or a depends upon > CONFIG_REGULATOR
Valid point, although it seems no consensus on which is better to use. It seems to me that in this case we need to select it.
-- With Best Regards, Andy Shevchenko
| |