Messages in this thread | | | Date | Tue, 19 Jan 2021 10:18:27 +0000 | From | Simon Ser <> | Subject | Re: [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes |
| |
On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul <lyude@redhat.com> wrote:
> Nvidia hardware doesn't actually support using tiling formats with the > cursor plane, only linear is allowed. In the future, we should write a > testcase for this. > > Fixes: c586f30bf74c ("drm/nouveau/kms: Add format mod prop to base/ovly/nvdisp") > Cc: James Jones <jajones@nvidia.com> > Cc: Martin Peres <martin.peres@free.fr> > Cc: Jeremy Cline <jcline@redhat.com> > Cc: Simon Ser <contact@emersion.fr> > Cc: <stable@vger.kernel.org> # v5.8+ > Signed-off-by: Lyude Paul <lyude@redhat.com>
Together with [1], this patch allows me to run unpatched modifier-aware user-space successfully, without a cursor visual glitch. drm_info correctly reports the new modifier list, and wlroots logs confirm that a flavor of NVIDIA_BLOCK_LINEAR_2D is used for the primary buffers and LINEAR is used for cursor buffers.
Code looks good to me as well.
Reviewed-by: Simon Ser <contact@emersion.fr>
[1]: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3724
| |