Messages in this thread | | | Date | Wed, 20 Jan 2021 00:02:44 +0100 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH v4 19/21] regulator: hi6421v600-regulator: move it from staging |
| |
Em Tue, 19 Jan 2021 16:19:50 +0000 Mark Brown <broonie@kernel.org> escreveu:
> On Tue, Jan 19, 2021 at 05:10:45PM +0100, Mauro Carvalho Chehab wrote: > > > +static int hi6421_spmi_regulator_get_voltage_sel(struct regulator_dev *rdev) > > +{ > > > +static int hi6421_spmi_regulator_set_voltage_sel(struct regulator_dev *rdev, > > + unsigned int selector) > > Now that the driver has been converted to regmap these are just > duplicates of the regmap helpers. You may also be able to use them for > the disable() and is_enabled() operations, I didn't confirm that that's > OK with the device using multi-bit enable controls for some reason IIRC.
True.
In order to avoid re-submitting 21 patches, I sent such change as patch 22/21 .
Thanks, Mauro
| |