lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings
Hi,

On Sat 16 Jan 21, 21:11, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> PTR_ERR should access the value just tested by IS_ERR

Good catch!

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> Fixes: 11c0d8fdccc5 ("media: i2c: Add support for the OV8865 image sensor")
> CC: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: b3a3cbdec55b090d22a09f75efb7c7d34cb97f25
> commit: 11c0d8fdccc56fa15cb15906480b4737c31dd085 [2650/3956] media: i2c: Add support for the OV8865 image sensor
> :::::: branch date: 2 days ago
> :::::: commit date: 4 days ago
>
> ov8865.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -2849,7 +2849,7 @@ static int ov8865_probe(struct i2c_clien
> sensor->avdd = devm_regulator_get(dev, "avdd");
> if (IS_ERR(sensor->avdd)) {
> dev_err(dev, "cannot get AVDD (analog) regulator\n");
> - ret = PTR_ERR(sensor->dvdd);
> + ret = PTR_ERR(sensor->avdd);
> goto error_endpoint;
> }
>

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-01-18 14:59    [W:0.061 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site