lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mm, oom: Fix a comment in dump_task
On Fri 15-01-21 22:23:14, Tang Yizhou wrote:
> If p is a kthread, it will be checked in oom_unkillable_task() so
> we can delete the corresponding comment.
>
> Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>
> Cc: David Rientjes <rientjes@google.com>
> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Shakeel Butt <shakeelb@google.com>
> Cc: Michal Hocko <mhocko@kernel.org>

Yes, this is outdated for a long time. Thanks
Acked-by: Michal Hocko <mhocko@suse.com>

> ---
> v2: Update Cc list
> mm/oom_kill.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 04b19b7b5435..9f043ad29554 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -395,9 +395,8 @@ static int dump_task(struct task_struct *p, void *arg)
> task = find_lock_task_mm(p);
> if (!task) {
> /*
> - * This is a kthread or all of p's threads have already
> - * detached their mm's. There's no need to report
> - * them; they can't be oom killed anyway.
> + * All of p's threads have already detached their mm's. There's
> + * no need to report them; they can't be oom killed anyway.
> */
> return 0;
> }
> --
> 2.22.0

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2021-01-18 11:27    [W:0.047 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site