Messages in this thread | | | From | Saravana Kannan <> | Date | Mon, 18 Jan 2021 14:11:51 -0800 | Subject | Re: [PATCH v1] of: property: Add fw_devlink support for "gpio" and "gpios" binding |
| |
On Mon, Jan 18, 2021 at 7:32 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Jan 15, 2021 at 10:02 PM Saravana Kannan <saravanak@google.com> wrote: > > > To provide backward compatibility for boards that use deprecated DT > > bindings, we need to add fw_devlink support for "gpio" and "gpios". > > > > Cc: linux-tegra <linux-tegra@vger.kernel.org> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > > Signed-off-by: Saravana Kannan <saravanak@google.com> > > "gpios" is a valid non legacy property I think.
I checked :) Quoting the documentation [1]: "While a non-existent <name> is considered valid for compatibility reasons (resolving to the "gpios" property), it is not allowed for new bindings."
[1] - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/gpio/gpio.txt#n8
> Anyways: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks!
Greg/Rob,
Can we pull this into driver-core-next please? It fixes issues on some boards with fw_devlink=on.
-Saravana
| |