lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset
On Mon, Jan 18, 2021 at 02:32:53PM +0800, Shawn Guo wrote:
> On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote:
> > RTC pcf2127 device driver has changed default behaviour of the watchdog
> > feature in v5.11-rc1. Now you need to explicitly enable it with a
> > device tree property, "reset-source", when used in the board design.
>
> It sound that the existing DTBs are broken by this default behaviour
> change?

I didn't do a representative research, but I expect that there are only
very few machines that have a working watchdog setup using the pcf2127.
All other machines were surprised by commit

0e735eaae165 ("rtc: pcf2127: add watchdog feature support")

because they suddenly had a non-functional watchdog device. The
alternative would be to "fix" the device trees of all these machines to
restore pre-v5.4-rc1 behaviour. This is IMHO worse.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-01-18 09:15    [W:0.083 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site