lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 24/43] ARM: picoxcell: fix missing interrupt-parent properties
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit bac717171971176b78c72d15a8b6961764ab197f ]

    dtc points out that the interrupts for some devices are not parsable:

    picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent
    picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent
    picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent
    picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent

    There are two VIC instances, so it's not clear which one needs to be
    used. I found the BSP sources that reference VIC0, so use that:

    https://github.com/r1mikey/meta-picoxcell/blob/master/recipes-kernel/linux/linux-picochip-3.0/0001-picoxcell-support-for-Picochip-picoXcell-SoC.patch

    Acked-by: Jamie Iles <jamie@jamieiles.com>
    Link: https://lore.kernel.org/r/20201230152010.3914962-1-arnd@kernel.org'
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/picoxcell-pc3x2.dtsi | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/arch/arm/boot/dts/picoxcell-pc3x2.dtsi b/arch/arm/boot/dts/picoxcell-pc3x2.dtsi
    index a1266cf8776ce..8362c6a3bcd30 100644
    --- a/arch/arm/boot/dts/picoxcell-pc3x2.dtsi
    +++ b/arch/arm/boot/dts/picoxcell-pc3x2.dtsi
    @@ -54,18 +54,21 @@
    emac: gem@30000 {
    compatible = "cadence,gem";
    reg = <0x30000 0x10000>;
    + interrupt-parent = <&vic0>;
    interrupts = <31>;
    };

    dmac1: dmac@40000 {
    compatible = "snps,dw-dmac";
    reg = <0x40000 0x10000>;
    + interrupt-parent = <&vic0>;
    interrupts = <25>;
    };

    dmac2: dmac@50000 {
    compatible = "snps,dw-dmac";
    reg = <0x50000 0x10000>;
    + interrupt-parent = <&vic0>;
    interrupts = <26>;
    };

    @@ -243,6 +246,7 @@
    axi2pico@c0000000 {
    compatible = "picochip,axi2pico-pc3x2";
    reg = <0xc0000000 0x10000>;
    + interrupt-parent = <&vic0>;
    interrupts = <13 14 15 16 17 18 19 20 21>;
    };
    };
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-01-18 20:36    [W:4.092 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site