lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 63/76] RDMA/usnic: Fix memleak in find_free_vf_and_create_qp_grp
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    commit a306aba9c8d869b1fdfc8ad9237f1ed718ea55e6 upstream.

    If usnic_ib_qp_grp_create() fails at the first call, dev_list
    will not be freed on error, which leads to memleak.

    Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
    Link: https://lore.kernel.org/r/20201226074248.2893-1-dinghao.liu@zju.edu.cn
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
    +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
    @@ -214,6 +214,7 @@ find_free_vf_and_create_qp_grp(struct us

    }
    usnic_uiom_free_dev_list(dev_list);
    + dev_list = NULL;
    }

    /* Try to find resources on an unused vf */
    @@ -239,6 +240,8 @@ find_free_vf_and_create_qp_grp(struct us
    qp_grp_check:
    if (IS_ERR_OR_NULL(qp_grp)) {
    usnic_err("Failed to allocate qp_grp\n");
    + if (usnic_ib_share_vf)
    + usnic_uiom_free_dev_list(dev_list);
    return ERR_PTR(qp_grp ? PTR_ERR(qp_grp) : -ENOMEM);
    }
    return qp_grp;

    \
     
     \ /
      Last update: 2021-01-18 19:44    [W:2.288 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site